Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed metrics generated on windows #2532

Closed
DerEwige opened this issue Dec 16, 2022 · 5 comments · Fixed by #2665
Closed

Malformed metrics generated on windows #2532

DerEwige opened this issue Dec 16, 2022 · 5 comments · Fixed by #2665

Comments

@DerEwige
Copy link
Contributor

When enabling promethus metrics several of the metrics are malformed on windows and can not be parsed by prometheus.

Eclair: version=0.8.0 commit=0077471

host_storage_device_data_read_bytes_total{device="\\.\PHYSICALDRIVE0",component="host"} 215866880.0
error while linting: text format parsing error in line 33: invalid escape sequence '\P'

You do not properly escape \ in file paths comming from windows

metrics.txt

@t-bast
Copy link
Member

t-bast commented Dec 16, 2022

Unfortunately we cannot do much here, we are not the ones generating those metrics.
You should open an issue https://github.com/kamon-io/Kamon, the library we use for metrics.

@DerEwige
Copy link
Contributor Author

Just found this old issue, from march last year =(
kamon-io/Kamon#958

@t-bast
Copy link
Member

t-bast commented Dec 16, 2022

Damn, they're not very good at fixing issues on their repositories...

@DerEwige
Copy link
Contributor Author

As a workaround I can just remove kamon-system-metrics_2.13-2.4.6.jar from my lib folder.
So it won't get loaded. This way I lose all system metrics, but the rest works

@DerEwige
Copy link
Contributor Author

@t-bast
the latest release conains the PR that fixes this issue

t-bast added a commit that referenced this issue May 22, 2023
@t-bast t-bast mentioned this issue May 22, 2023
t-bast added a commit that referenced this issue May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants