Anchor output transaction format #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us re-use most of our existing transaction utilities for anchor outputs. Channels will always use the default commitment format (current spec), but we will be able to change that by setting the `ChannelVersion` to something appropriate for anchor outputs (and later other commitment formats).
Remove obsolete claim-htlc tests: they used a different format from what lightning uses and are redundant with existing tests in TransactionsSpec. Add missing test cases in TransactionsSpec.
Add support for creating an anchor outputs commitment transaction, without any HTLC. Support for the new HTLC format will be added in a separate change.
For anchor outputs, some values will not match the hard-coded ones. We will instead need to read from the test vector.
Anchor outputs isn't fully implemented yet, so we need to ignore the tests that are currently not passing.
Add support for HTLC transactions with a 1-block relative delay. Add missing anchor outputs spec tests. Add missing tests for some revoked paths.
t-bast
force-pushed
the
anchor-output-commit-tx
branch
from
6a58436
to
0ea4378
Compare
sstone
reviewed
Jul 20, 2020
Yes we will :) But this is done in a later PR (currently being worked on) that focuses on the changes to The current PR adds all the script/transaction format capabilities, but doesn't exploit them yet. |
For simplicity's sake, we always subtract both anchors from the funder's main output, even if only one anchor materializes.
sstone
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a first step towards the anchor outputs commitment format.
It implements all the transaction format changes and passes official test vectors.
It's currently only raw transaction/script code and will at first be unreachable (until support is added in higher layers to negotiate the feature at channel opening time).
We're implementing this feature from the bottom up to be able to integrate small chunks to master safely.
Some clean-up/refactoring was necessary, so I advise to review commit-by-commit.
NB: there is one area where we currently diverge from lnd, in the case where only one of the anchor outputs is added (prunedto_remote). We are still clarifying what the behavior should be on the spec PR, I'll update here once there's consensus between implementations on the expected behavior).EDIT: we confirmed during the spec meeting that both anchors should always be deduced for simplicity's sake. This is done in fefd076, which makes this PR fully spec compliant.