-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leak and reduce overall memory usage #365
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2b171e6c37611a6916b1a483)
otherwise, this would frequently cause 2 successful parallel connections
Instead, just check this particular watch
…s when auto connecting
This reverts commit d276139.
pm47
changed the title
[WIP] Fix memory leak and reduce overall memory usage
Fix memory leak and reduce overall memory usage
Jan 10, 2018
sstone
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds better management of resources, mainly:
authenticator
PreparedStatement
are now explicitely closedorigins
map (which allows to not ping-pong announcements to the same peer) has been removed, instead the stash/rebroadcast/awaiting collections all maintain a reference to the origin peerWhen a channel enters the
CLOSING
state:min_depth
, and don't republish/watch them on restartmin_depth
Also, the zmq watcher doesn't trigger a
TickNewBlock
on newWatchConfirmed
anymore, this was causing a massive herd effect on startup.Note that this PR implies a non-backward-compatible change in
DATA_CLOSING
.Fixes #357.