Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emphasized and shortened message in notifications #55

Merged
merged 1 commit into from
Apr 4, 2017
Merged

Emphasized and shortened message in notifications #55

merged 1 commit into from
Apr 4, 2017

Conversation

dpad85
Copy link
Member

@dpad85 dpad85 commented Apr 3, 2017

  • message notification should be straightforward and as brief as possible
  • message does not wrap anymore
  • notification is not interactive anymore (expand on click)
  • updated notifications icons
  • fixed issue with uncaught escape key hiding the whole notification scene

@dpad85
(gui) Shortened notification and emphasized message
f49b887 
* fixed uncaught escape key hiding notification scene
* message notification should be straightforward and as brief as possible
* updated notifications icons
@dpad85 dpad85 requested review from pm47 and sstone April 3, 2017 15:51
@pm47 pm47 merged commit 00c9aa6 into master Apr 4, 2017
@pm47 pm47 deleted the wip-notifications branch April 4, 2017 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pm47 pm47 pm47 approved these changes

@sstone sstone Awaiting requested review from sstone

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpad85 @pm47