feat(dialog): open buildCustomView for override

[mikehardy]

This allows complicated dynamic views in sub-classes
Related: ankidroid/Anki-Android#7805 (comment)

[F43nd1r]

Might be better to just put an @OpenAPI on the class instead of opening specific methods

[mikehardy]

I mean this literally: whatever you prefer :-), I went surgical / minimal-intervention first
I must admit I'm not familiar with @OpenAPI as an annotation, and a quick search turned nothing up for me 🤔

[F43nd1r]

I must admit I'm not familiar with @openapi as an annotation, and a quick search turned nothing up for me 🤔

That is because it is acra-specific configuration. If you want to google what it does, you need to look for kotlin all-open, which in our case is used as gradle plugin.

Shortform is: Makes the class and all members open by default, as it would be in java.

[mikehardy]

@F43nd1r oh that makes sense, then how does the combined effect of the two commits look? Is that what you were thinking?

If it was you'll either need to squash merge now or I can clean up by pulling the repo down local and rebasing - which implies that no I have not compile tested even and only now I see there's no CI here 😨 but I'll see what you think first

[F43nd1r]

the open keyword is redundant with the annotation present

[F43nd1r]

Huh, looks like I never enabled tests for PRs 🤔

Also note that this will most likely not make it into any 5.8 release, as I've already started 5.9 development cycle.

[mikehardy]

There's also no workflow_dispatch event on them so you can't manually run them on a branch if you want :)
Looks like this if you want it: #1034

[mikehardy]

Totally fine waiting for 5.9.x by the way, we've waited this long to handle the move away from annotations even! AnkiDroid is bogged down in other large projects soaking up our dev time

[mikehardy]

Okay, no more messing around ;-)
I pulled it locally, rebased against master here, cleaned up the commits, addressed your comment, then pushed it
Action running now: https://github.com/mikehardy/acra/actions

[F43nd1r]

Every time I think I know it'll work, something happens. I fixed it on master.