fix(core, reporter): default exception handler may be null #1053
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Underlying Java API documents it as potentially null
https://developer.android.com/reference/java/lang/Thread#getDefaultUncaughtExceptionHandler()
Null values are handled in ReportExecutor (the only consumer of this value that I know of?):
acra/acra-core/src/main/java/org/acra/builder/ReportExecutor.kt
Line 51 in 042eddd
Fixes a crash in robolectric contexts where it actually is null
Test Plan: I made the correct package directory structure, copied the original version of the file in to AnkiDroid's codebase that way and ran it - reproduce the failure in our robolectric tests - ran this changed version and it worked
Also
./gradlew test
passed locally