StartupProcessor enhancements #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting old reports after app update. Deprecated old option. Limiter can also delete its own config after app update.
|
Wow, that's the full capture / implementation of the idea - I'll use the API you mention in case a user toggles their reporting state (something that indicates they're purposefully wanting to log errors usually), but the deleteReportsOnAppUpdate and resetLimitsOnAppUpdate are also perfect and the true default is also the right direction I think. Chapeau, the next version will allow me to delete code in my codebase, my favorite thing. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #694
@mikehardy you can call
new LimiterData().store(context)to clear limiter data manually.