-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DirectBoot support added #889
Conversation
The docs are unclear on how using device protected context affects files in credential protected contexts. Did you test this with credential protected shared preferences? |
Yes, I have tested this with device protected storage and it is working perfectly. Credential encrypted storage, which is the default storage location and only available after the user has unlocked the device. Device encrypted storage, which is a storage location available both during Direct Boot mode and after the user has unlocked the device. |
That's not what I'm asking. I want to know if it could break anything for existing apps which don't need this. |
No, It will not break anything for existing users. because it will save in device protected storage and will read from device protected storage. There is a scenerio in which it may break i.e prefereces saved in CES and user updated library after that ACRA try to read from DES in API 7+ devices. but I think this scenerio will never happen. |
That sounds like a very common scenario, as CES is default and many apps are already using ACRA and might upgrade. |
Ok for this we have to add supportDirectBoot in Builder, so only people who what this feature can enable this. |
Yes, a config option would be good. I'm unsure if it should be the same config option for collector and ACRA settings or if it should be two options. |
Should be a single option, if the user enables a single option then it will not work, so both have to be in the same storage. |
@Shahzainali if you implement this as an option I can get it merged. |
Hi @F43nd1r I will implement this within 2 days :) Thanks |
ACRA was crashing in DirectBoot mode supported applications due to Shared Preferences, added support for this.