Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version check for getDeviceId #890

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Add version check for getDeviceId #890

merged 2 commits into from
Dec 10, 2021

Conversation

DSOTM-pf
Copy link
Contributor

@DSOTM-pf DSOTM-pf commented Aug 5, 2021

Fix for issue #887.

Copy link
Member

@F43nd1r F43nd1r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also mark the DEVICE_ID report field as deprecated, with a note that it'll be empty on newer devices

add @deprecated("DEVICE_ID will be null on Android Q and above") for DEVICE_ID in ReportField
@DSOTM-pf
Copy link
Contributor Author

DSOTM-pf commented Aug 8, 2021

Hello, I add Deprecated annotation for DEVICE_ID with "DEVICE_ID will be null on Android Q and above" in ReportField file.
Thanks for your reply!

@DSOTM-pf DSOTM-pf requested a review from F43nd1r August 9, 2021 02:57
Copy link
Member

@F43nd1r F43nd1r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@F43nd1r F43nd1r added this to the ACRA 5.9.0 milestone Aug 9, 2021
@F43nd1r F43nd1r merged commit 805581c into ACRA:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants