Skip to content

Wan checkpointing #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 18, 2025
Merged

Wan checkpointing #246

merged 6 commits into from
Sep 18, 2025
+61 −6

Conversation

coolkp
Copy link
Collaborator

@coolkp coolkp commented Sep 16, 2025

Fixed issue of >flash_block_sizes in config or cli, causes saving the checkpoint to crash.
Changed behavior

  • Parse objects of dataclasses correctly
  • Skip with warning incompatible fields (this is harmless since checkpointing is for checkpointing mainly model config and weights and restore args for checkpoint only use that.)
    Added test for verifying.

@github-actions GitHub Actions
Copy link

e2e testgrid: https://8bcf50593faf4ea38060e236169827e5-dot-us-central1.composer.googleusercontent.com/dags/maxdiffusion_tpu_e2e/grid

entrpn
entrpn previously approved these changes Sep 16, 2025
View reviewed changes
@coolkp coolkp force-pushed the wan-checkpointing-test branch from 4745a70 to 811a133 Compare September 16, 2025 18:15
entrpn
entrpn previously approved these changes Sep 16, 2025
View reviewed changes
@coolkp coolkp force-pushed the wan-checkpointing-test branch from 811a133 to 61bbe80 Compare September 16, 2025 19:55
@coolkp coolkp merged commit f41036d into main Sep 18, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@entrpn entrpn entrpn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coolkp @entrpn