Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend gather metrics pipeline for multiple deployments #143

Merged

Conversation

pacospace
Copy link

Signed-off-by: Francesco Murdaca fmurdaca@redhat.com

Related Issues and Dependencies

Related-To: #118
Related-To: AICoE/elyra-aidevsecops-tutorial#297

@sesheta sesheta added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 30, 2021
@pacospace pacospace force-pushed the feature/gather-metrics-multiple-deployments branch from 0fd018d to f29e9e8 Compare September 30, 2021 10:11
@sesheta sesheta added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 30, 2021
@pacospace pacospace force-pushed the feature/gather-metrics-multiple-deployments branch 2 times, most recently from 32187a0 to 426cc2e Compare October 4, 2021 10:00
@sesheta sesheta added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 4, 2021
@pacospace pacospace force-pushed the feature/gather-metrics-multiple-deployments branch from 426cc2e to a67d15d Compare October 4, 2021 16:38
Signed-off-by: Francesco Murdaca <fmurdaca@redhat.com>
@pacospace pacospace force-pushed the feature/gather-metrics-multiple-deployments branch from a67d15d to 71e876d Compare October 5, 2021 13:46
@sesheta sesheta added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 5, 2021
@AICoE AICoE deleted a comment from todo bot Oct 5, 2021
@pacospace pacospace force-pushed the feature/gather-metrics-multiple-deployments branch 4 times, most recently from 80ef662 to 31c2d93 Compare October 8, 2021 10:58
@pacospace pacospace changed the title WIP: Extend gather metrics pipeline for multiple deployments Extend gather metrics pipeline for multiple deployments Oct 11, 2021
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2021
@pacospace pacospace force-pushed the feature/gather-metrics-multiple-deployments branch from 31c2d93 to b9ce171 Compare October 11, 2021 07:30
Signed-off-by: Francesco Murdaca <fmurdaca@redhat.com>
@pacospace pacospace force-pushed the feature/gather-metrics-multiple-deployments branch from b9ce171 to 7b8139f Compare October 11, 2021 08:32
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks for the work 💯

@sesheta
Copy link
Contributor

sesheta commented Nov 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2021
@harshad16 harshad16 merged commit a6bd84c into AICoE:master Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants