Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub V4 API support for label_normalizer #32

Merged
13 commits merged into from
May 31, 2020
Merged

GitHub V4 API support for label_normalizer #32

13 commits merged into from
May 31, 2020

Conversation

goern
Copy link
Member

@goern goern commented May 23, 2020

this version of 'label_normaliyer' uses GitHub's V4 API to get repos and their labels

Signed-off-by: Christoph Görn goern@redhat.com

This introduces a breaking change

  • Yes
  • No

Description

new_label_normalizer uses GitHub V4 API to query for all the repositories and their labels, then reconciles the labels based on the default labels defined, this happens via V3 API

@todo
Copy link

todo bot commented May 23, 2020

we could go ahead and check if we need to get some more labels due to pagination

https://github.com/AICoE/Sefkhet-Abwy/blob/a829998714fab121d42c75c94d508599da371c1c/aicoe/sesheta/new_label_normalizer.py#L151-L156

This comment was generated by todo based on a TODO comment in a829998 in #32. cc @goern.

@sefkhet-abwy sefkhet-abwy bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 23, 2020
@ghost
Copy link

ghost commented May 23, 2020

Build succeeded.

@todo
Copy link

todo bot commented May 25, 2020

spiral_notepad:"):

https://github.com/AICoE/Sefkhet-Abwy/blob/2ffbfdeb8e86ba872a056b776e9fe4bad2894632/aicoe/sesheta/new_label_normalizer.py#L206-L211

This comment was generated by todo based on a todo comment in 2ffbfde in #32. cc @goern.

@sefkhet-abwy sefkhet-abwy bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 25, 2020
@todo
Copy link

todo bot commented May 25, 2020

labelsToBeAdded.append(default_label)

https://github.com/AICoE/Sefkhet-Abwy/blob/2ffbfdeb8e86ba872a056b776e9fe4bad2894632/aicoe/sesheta/new_label_normalizer.py#L220-L225

This comment was generated by todo based on a TODO comment in 2ffbfde in #32. cc @goern.

@ghost
Copy link

ghost commented May 25, 2020

Build failed.

@goern
✨ this version of 'label_normaliyer' uses GitHub's V4 API to get repo…
cf6bcf3 
…s and their labels

Signed-off-by: Christoph Görn <goern@redhat.com>
@goern goern force-pushed the feature/graphql-based-label-normalizer branch from 2ffbfde to cf6bcf3 Compare May 25, 2020 09:20
@todo
Copy link

todo bot commented May 25, 2020

some exception handling would be nice...

https://github.com/AICoE/Sefkhet-Abwy/blob/cf6bcf3308c9ca63682018e14120ba3ba82104e3/aicoe/sesheta/new_label_normalizer.py#L205-L210

This comment was generated by todo based on a TODO comment in cf6bcf3 in #32. cc @goern.

@ghost
Copy link

ghost commented May 25, 2020

Build failed.

@goern
commit by error
05ae6b6 
Signed-off-by: Christoph Görn <goern@redhat.com>
@ghost
Copy link

ghost commented May 25, 2020

Build succeeded.

@goern goern mentioned this pull request May 25, 2020
Closed
goern and others added 9 commits May 30, 2020 17:23
@goern
some minor parsing of incoming messages
d19dace 
Signed-off-by: Christoph Görn <goern@redhat.com>
@saisankargochhayat @goern
Added function to create releases
a0d4a3d
@goern
stipping username from public messages
23c3a79 
Signed-off-by: Christoph Görn <goern@redhat.com>
@saisankargochhayat @goern
We can log the incoming json
463ae6c
@saisankargochhayat @goern
Lets pass the parsed text
6ceeede
@goern
🐛 fixed coala issues
038650a 
Signed-off-by: Christoph Görn <goern@redhat.com>
@goern
🐛 fixed coala issues
9bfcb86 
Signed-off-by: Christoph Görn <goern@redhat.com>
@harshad16 @goern
Respect Null response of github api attrib
56fe661 
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@harshad16 @goern
use the whole branch name for tag
5f5dea4 
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@todo
Copy link

todo bot commented May 30, 2020

add more message types like deliver or tag release of.

https://github.com/AICoE/Sefkhet-Abwy/blob/5f5dea41cfab6c8b416bc96d08169a463033adf9/aicoe/sesheta/messages.py#L20-L25

This comment was generated by todo based on a TODO comment in 5f5dea4 in #32. cc @goern.

@ghost
Copy link

ghost commented May 30, 2020

Build succeeded.

@goern
✨ minor tweaks
fd25396 
Signed-off-by: Christoph Görn <goern@redhat.com>
@goern goern changed the title [WIP] GitHub V4 API support GitHub V4 API support for label_normalizer May 30, 2020
@sefkhet-abwy sefkhet-abwy bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2020
@ghost
Copy link

ghost commented May 30, 2020

Build succeeded.

@goern goern requested review from bissenbay and removed request for fridex May 30, 2020 20:28
harshad16
harshad16 reviewed May 30, 2020
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@goern
added descriptions to all DEFAULT_LABELS
b644d7c 
Signed-off-by: Christoph Görn <goern@redhat.com>
@goern goern requested a review from harshad16 May 31, 2020 06:55
@ghost
Copy link

ghost commented May 31, 2020

Build succeeded.

harshad16
harshad16 approved these changes May 31, 2020
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sefkhet-abwy sefkhet-abwy bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2020
@ghost
Copy link

ghost commented May 31, 2020

Build succeeded (gate pipeline).

@ghost ghost merged commit 2e93d6c into AICoE:master May 31, 2020
This was referenced May 31, 2020
Closed
Closed
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@bissenbay bissenbay Awaiting requested review from bissenbay

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goern @harshad16 @saisankargochhayat