Skip to content

Removed micronaut from saga test. #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2019
Merged

Removed micronaut from saga test. #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d3b6c7
Removed micronaut from saga test.
Castyr Apr 2, 2019
de365fd
Removed bug in the transfer process, there are now no serious bugs em…
Castyr Apr 2, 2019
e24b73d
Merge branch 'master' into service-integration-testing
Castyr Apr 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ccount-cmd/src/main/java/com/ultimatesoftware/banking/account/cmd/aggregates/Account.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ public void on(DebitAccountCommand debitAccountCommand) throws Exception {
applyEvent(TransferWithdrawConcludedEvent.builder()
.id(debitAccountCommand.getId().toHexString())
.balance(newBalance.doubleValue())
.amount(debitAccountCommand.getAmount())
.transactionId(debitAccountCommand.getTransactionId())
.build());
} else {
Expand Down
2 changes: 1 addition & 1 deletion ...unt-cmd/src/main/java/com/ultimatesoftware/banking/account/cmd/sagas/TransactionSaga.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public void handle(TransferWithdrawConcludedEvent event) {
withdrawCompleted = true;
try {
CreditAccountCommand command
= new CreditAccountCommand(destinationAccountId, event.getBalance(), event.getTransactionId(), true);
= new CreditAccountCommand(destinationAccountId, event.getAmount(), event.getTransactionId(), true);
commandGateway.send(command);
} catch (Exception e) {
commandGateway.send(new FailTransactionCommand(sourceAccountId, destinationAccountId, transactionId, e.getMessage()));
Expand Down
4 changes: 3 additions & 1 deletion ...main/java/com/ultimatesoftware/banking/account/events/TransferWithdrawConcludedEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,13 @@
@Getter
@JsonDeserialize(builder = TransferTransactionStartedEvent.TransferTransactionStartedEventBuilder.class)
public class TransferWithdrawConcludedEvent extends AccountTransactionEvent {
private double amount;
private double balance;

@Builder
protected TransferWithdrawConcludedEvent(String id, double balance, String transactionId) {
protected TransferWithdrawConcludedEvent(String id, double amount, double balance, String transactionId) {
super(id, transactionId);
this.amount = amount;
this.balance = balance;
}

Expand Down
2 changes: 0 additions & 2 deletions .../java/com/ultimatesoftware/banking/account/cmd/tests/unit/social/TransactionSagaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,12 @@
import com.ultimatesoftware.banking.account.events.TransferDepositConcludedEvent;
import com.ultimatesoftware.banking.account.events.TransferTransactionStartedEvent;
import com.ultimatesoftware.banking.account.events.TransferWithdrawConcludedEvent;
import io.micronaut.test.annotation.MicronautTest;
import org.axonframework.test.saga.SagaTestFixture;
import org.bson.types.ObjectId;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

@MicronautTest
@Disabled
public class TransactionSagaTest {
private static final String accountId = ObjectId.get().toHexString();
Expand Down
4 changes: 3 additions & 1 deletion ...main/java/com/ultimatesoftware/banking/account/events/TransferWithdrawConcludedEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,13 @@
@JsonDeserialize(builder = TransferWithdrawConcludedEvent.TransferWithdrawConcludedEventBuilder.class)
public class TransferWithdrawConcludedEvent extends AccountTransactionEvent {
private double balance;
private double amount;

@Builder
protected TransferWithdrawConcludedEvent(String id, double balance, String transactionId) {
protected TransferWithdrawConcludedEvent(String id, double amount, double balance, String transactionId) {
super(id, transactionId);
this.balance = balance;
this.amount = amount;
}

@JsonPOJOBuilder(withPrefix = "")
Expand Down