Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BFE product name. #41

Merged
merged 10 commits into from
Apr 13, 2022
Merged

Update BFE product name. #41

merged 10 commits into from
Apr 13, 2022

Conversation

mohsen-bfe
Copy link
Contributor

No description provided.

Copy link
Contributor

@garethsb garethsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm: the web page for KSC CORE only mentions IS-07, is that right? (I think the brochure doesn't mention NMOS at all.) The web page for KSC SILKNET mentions IS-04, IS-05 and IS-07, though the brochure doesn't mention IS-07, as far as I can see.

docs/5.0. NMOS Solutions.md Outdated Show resolved Hide resolved
@mohsen-bfe
Copy link
Contributor Author

@garethsb Thanks for your prompt response.

KSC CORE only mentions IS-07, because the IS-07 functionality is focused here (IS-04, and IS-05 are included implicitly)

I will update brochures as well.

@garethsb
Copy link
Contributor

Thanks, makes sense to me. I expect @peterbrightwell will then approve / merge. 👍

@peterbrightwell
Copy link
Contributor

Thanks, yes I'll approve and merge when updated.

P

@peterbrightwell
Copy link
Contributor

@mohsen-bfe are updates done yet?

@mohsen-bfe
Copy link
Contributor Author

@peterbrightwell Sorry for my delayed response, not yet, I will write here when are done. Thanks.

@peterbrightwell
Copy link
Contributor

@mohsen-bfe any update on this? The PR will now need conflicts resolved also.

@mohsen-bfe
Copy link
Contributor Author

@peterbrightwell, the brochures are updated.

Copy link
Contributor

@garethsb garethsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbrightwell
Copy link
Contributor

THanks @mohsen-bfe , merging now

@peterbrightwell peterbrightwell merged commit c383f5d into AMWA-TV:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants