-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add second version of N3 #126
Conversation
Hey @stnava , can you provide a bit more detail about tagging an ITKR version? As you can see, this pull request is still failing due to the recent migration of certain classes to the AdaptiveDenoising module and those classes are somehow not available to programs in ANTsRCore. However, I've checked and it looks like the correct ITK git tag is there in both the ITKR and ANTsRCore repos. I've tried clearing the travis build caches but I can't get the repo to build. Thanks. |
You need to tag the release for ITKR so that it creates a release because
it takes forever to build it, we use the binary release from GitHub. So
for Travis, you need to use a binary ITKR that reflects this: See
https://travis-ci.org/github/ANTsX/ANTsRCore/jobs/735786279#L6943 for wh
Best,
John
…On Thu, Oct 15, 2020 at 11:47 AM Nick Tustison ***@***.***> wrote:
Hey @stnava <https://github.com/stnava> , can you provide a bit more
detail about tagging an ITKR version? As you can see, this pull request is
still failing due to the recent migration of certain classes to the
AdaptiveDenoising module and those classes are somehow not available to
programs in ANTsRCore. However, I've checked and it looks like the correct
ITK git tag is there in both the ITKR and ANTsRCore repos. I've tried
clearing the travis build caches but I can't get the repo to build. Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#126 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIGPLUDKBYGICDSDTX24T3SK4KQBANCNFSM4SNFOXGA>
.
|
Awesome. Thanks for the explanation (and relief from the frustration of trying to figure out what I was missing)---much appreciated, @muschellij2 . |
Thanks @stnava for the ITKR tag update. It looks like it's passing now. |
The required builds are all green. |
No description provided.