This repository has been archived by the owner on May 7, 2024. It is now read-only.
meta: introduce default GOFLAGS definition #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- etc/autobuild/ab3_defcfg.sh: set default GOFLAGS - arch/loongson3.sh: disable go's buildmode=pie - build/15-gomod.sh: remove redundant check and codepath for loongson3
CamberLoid
changed the title
- etc/autobuild/ab3_defcfg.sh: add comment to marking its reference - arch/(multiple arches): disable PIE for other retro architectures
This will fix an issue where one GOFLAG is not applied.
|
LGTM on amd64 |
2 tasks
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent aosc-os-abbs topic Go-1.18-survey-20220401 , it is found that similar GOFLAGS is defined repeatably, making build script harder to read. This pull request attempt to resolve aforementioned issue and may make further packaging for go-based project easilier.
File changes:
etc/autobuild/ab3_defcfg.sh: set defaultGOFLAGSarch/loongson3.sh: disable go's-buildmode=piebuild/15-gomod.sh: remove redundant check and codepath for loongson3