Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#98: Pass $refs to resolvers #124

Merged
merged 2 commits into from
Jun 21, 2019
Merged

#98: Pass $refs to resolvers #124

merged 2 commits into from
Jun 21, 2019

Conversation

ziadsawalha
Copy link
Contributor

This allows resolvers to understand more of
the context around what they are resolving.

Ex. $refs._root$Ref.path indicates
the file being dereferenced.

@ziadsawalha ziadsawalha changed the title Pass $refs to resolves (#98) Pass $refs to resolvers (#98) Apr 16, 2019
@ziadsawalha ziadsawalha force-pushed the feature/98-pass_refs_to_resolvers branch from 1074a72 to 92ac8de Compare April 16, 2019 21:00
@ziadsawalha ziadsawalha changed the title Pass $refs to resolvers (#98) #98: Pass $refs to resolvers Apr 16, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 335

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 92.877%
Totals Coverage Status
Change from base Build 331: -0.9%
Covered Lines: 665
Relevant Lines: 702
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 335

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 92.877%
Totals Coverage Status
Change from base Build 331: -0.9%
Covered Lines: 665
Relevant Lines: 702
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 335

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.732%
Totals Coverage Status
Change from base Build 331: 0.0%
Covered Lines: 668
Relevant Lines: 702
💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 16, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 337

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.732%
Totals Coverage Status
Change from base Build 331: 0.0%
Covered Lines: 668
Relevant Lines: 702
💛 - Coveralls

@ziadsawalha
Pass $refs to resolvers (APIDevTools#98)
3eebea7 
This allows resolvers to understand more of
the context around what they are resolving.

Ex. `$refs._root$Ref.path` indicates
the file being dereferenced.
@ziadsawalha ziadsawalha force-pushed the feature/98-pass_refs_to_resolvers branch from 92ac8de to 3eebea7 Compare April 26, 2019 13:31
@JamesMessinger JamesMessinger merged commit 20143f1 into APIDevTools:master Jun 21, 2019
@JamesMessinger
Copy link
Member

Sorry this took me so long to merge. Thank you for the work!

@philsturgeon philsturgeon mentioned this pull request Nov 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ziadsawalha @coveralls @JamesMessinger