Skip to content

Updating to use Treeware #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Updating to use Treeware #156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0b3b13
Updating to use Treeware
jamesmills Mar 10, 2020
8bc7fa4
Committing the changed wording
JamesMessinger Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ JSON Schema $Ref Parser
[![npm](https://img.shields.io/npm/v/json-schema-ref-parser.svg)](https://www.npmjs.com/package/json-schema-ref-parser)
[![Dependencies](https://david-dm.org/APIDevTools/json-schema-ref-parser.svg)](https://david-dm.org/APIDevTools/json-schema-ref-parser)
[![License](https://img.shields.io/npm/l/json-schema-ref-parser.svg)](LICENSE)
[![Buy us a tree](https://img.shields.io/badge/Treeware-%F0%9F%8C%B3-lightgreen)](https://click.treeware.earth/APIDevTools/json-schema-ref-parser)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link goes to a 404 page. Is that just a temporary problem? Should we instead link directly to https://offset.earth/treeware?gift-trees instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best you leave the link to go via our click URL. This will allow us to track the trees in our forest which came from your project. This is a work in progress as I work with Offset.Earth guys on this.

The URL will work once you have added the Treeware licence and then added your package to the website https://treeware.earth/#add-package-section (our website checks you have the licence in your README).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guys, I have added a quick message on the website to show you that the Click URL will work once you have added the README and added the package to the Treeware website.

https://click.treeware.earth/APIDevTools/json-schema-ref-parser

Hope this helps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great @jamesmills. Much better and more informative than the empty 404 page 👍

Question though... what exactly do you check for to verify that the Treeware license has been added to the ReadMe? Does it require certain wording? Or does it just check for the badge? Or just the link?

Why even require a check at all? Seems like an unnecessary roadblock to me that will lower the adoption rate of Treeware. Maybe somebody doesn't want to add anything to their ReadMe, but they want to link to Treeware in their docs, or maybe even in their product.



[![OS and Browser Compatibility](https://apitools.dev/img/badges/ci-badges-with-ie.svg)](https://travis-ci.com/APIDevTools/json-schema-ref-parser)
Expand Down Expand Up @@ -146,6 +147,9 @@ License
--------------------------
JSON Schema $Ref Parser is 100% free and open-source, under the [MIT license](LICENSE). Use it however you want.

If you use JSON Schema $Ref Parser, then we ask that you [**buy the world a tree**](https://click.treeware.earth/APIDevTools/json-schema-ref-parser) to thank us for our work.

By contributing to the Treeware forest you’ll be creating employment for local families and restoring wildlife habitats. Read more about Treeware at [treeware.earth](http://treeware.earth)
Big Thanks To
--------------------------
Thanks to these awesome companies for their support of Open Source developers ❤
Expand Down