Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Make sure that paginators are aliased to pagination.IStaticPage etc. as the mappers were not enough #43

Merged
merged 17 commits into from
May 22, 2024

Conversation

joshjennings98
Copy link
Contributor

Description

Make sure that paginators are aliased to pagination.IStaticPage etc. as the mappers were not enough. It was impossible to cast between the mapped struct and the various structs we want to map between due to type mismatches between client.IStaticPage and pagination.IStaticPage. This is the simplest solution.

Test Coverage

  • This change is covered by existing or additional automated tests.
  • Manual testing has been performed (and evidence provided) as automated testing was not feasible.
  • Additional tests are not required for this change (e.g. documentation update).

@joshjennings98 joshjennings98 changed the title 🐛 Make sure that paginators are aliased to pagination.IStaticPage etc. as the mappers were not enough 🐛 Make sure that paginators are aliased to pagination.IStaticPage etc. as the mappers were not enough May 8, 2024
@acabarbaye acabarbaye merged commit 79bc018 into main May 22, 2024
7 checks passed
@acabarbaye acabarbaye deleted the paginators branch May 22, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants