Skip to content

Change the default build dir to 'build' #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2016

Conversation

screamerbg
Copy link
Contributor

@screamerbg screamerbg commented Sep 16, 2016

This PR changes the default build dir from .build to build.

Also adds '.mbedignore' to ensure that contents of build are not scanned/included by the build system and reflects the change in the documentation.

Addressing #334 #206

@jaustin @MarceloSalazar @sg- @theotherjimmy

Also add '.mbedignore' to ensure that contents of build are not
scanned/included by the build system and reflect the change in the documentation
@bridadan
Copy link
Contributor

@screamerbg Has this been tested when building tests? The test building process includes files from the build directory as source files.

@bridadan
Copy link
Contributor

Also, I will need to update mbed-os CI will need to be updated to use the build directory now and not .build. I will look into this.

@screamerbg
Copy link
Contributor Author

@bridadan That's why I'm raising these with you :)
CC @jupe

@sg-
Copy link
Contributor

sg- commented Sep 16, 2016

this needs to be BUILD

@theotherjimmy
Copy link
Contributor

Any particular reason for the capitalization @sg-?

@jupe
Copy link

jupe commented Sep 16, 2016

CC: @miklis @marhil01 : this probably affected to our ci as well..

@sg-
Copy link
Contributor

sg- commented Sep 16, 2016

based on upcoming code base and API guidelines, any directory that is treated as magic will be capitalized.

@screamerbg
Copy link
Contributor Author

Agree with @sg-. Now changed to 'BUILD'

@sg-
Copy link
Contributor

sg- commented Sep 22, 2016

LGTM 👍

@screamerbg
Copy link
Contributor Author

@bridadan @jupe @miklis @marhil01 Can you confirm that the CIs are ready for this change?

@bridadan
Copy link
Contributor

@screamerbg I've pinned the CI to use the current mbed-cli version for now (v0.9.5) so this change should not affect the Austin CI. I will migrate the jobs to the newest version of mbed-cli after this has been released.

@screamerbg
Copy link
Contributor Author

@bridadan Thanks for the response.

@jupe @miklis @marhil01 The new mbed CLI will be released tomorrow. The PR was up for 11 days now so I hope you managed to transition the CI to either use the --build option or bind the CI to specific version of mbed CLI.

@screamerbg screamerbg merged commit 7611f84 into ARMmbed:master Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants