Remove unnecessary creation of BUILD dir for certain commands. #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
screamerbg
reviewed
Jan 18, 2017
mbed/mbed.py
Outdated
| + ['-t', tchain, '-m', target] | ||
| + list(chain.from_iterable(izip(repeat('--profile'), profile or []))) | ||
| + list(chain.from_iterable(izip(repeat('--source'), source))) | ||
| + ['--build', build] |
There was a problem hiding this comment.
Can you align build with build_path naming below for consistency?
mbed CLI was creating the BUILD directory even in cases where it wasn't needed. This PR deferes the creation of the BUILD dir until before compile steps only.
bridadan
force-pushed
the
build_dir_fixes
branch
from
fc9eb2c to
277854f
Compare
|
Thanks for the feedback @screamerbg, could you take a look again? |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mbed CLI was creating the BUILD directory even in cases where it wasn't needed. This PR defers the creation of the BUILD dir until before compile steps only.
This should fix #413.