Skip to content

Include tests in PyPI tarball #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Conversation

dotlambda
Copy link
Contributor

This is useful for downstream distributions to test if the package works correctly with their build recipe. Also, it provides a way to test if the dependencies as they are packaged by the distribution are compatible.

@bridadan
Copy link
Contributor

Hi @dotlambda, could you explain your use case a bit more? Which distribution in particular are you interested in supporting? And how will you be running the tests? If we do merge this, I'd like to be able to make sure we don't break how you run tests as well. Thanks!

@dotlambda
Copy link
Contributor Author

It's for NixOS: NixOS/nixpkgs#53954
We'll simply run py.test test.

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context. Seems fine to me, any opinions @theotherjimmy?

@theotherjimmy
Copy link
Contributor

seems fine to me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants