Skip to content
This repository was archived by the owner on Jul 27, 2020. It is now read-only.

💚️ Upload coverage results for all host platforms to codecov #25

Merged
merged 3 commits into from
Feb 28, 2020

Conversation

madchutney
Copy link
Contributor

Description

Code coverage had dropped to 30% because the coverage was only being uploaded for Linux. Normally this is ok but for Mbed Devices there is a large amount of host platform specific code.

Test Coverage

  • This change is covered by existing or additional automated tests.
  • Manual testing has been performed (and evidence provided) as automated testing was not feasible.
  • Additional tests are not required for this change (e.g. documentation update).

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #25 into master will increase coverage by 62.77%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #25       +/-   ##
===========================================
+ Coverage   30.98%   93.76%   +62.77%     
===========================================
  Files          29       29               
  Lines         994      994               
===========================================
+ Hits          308      932      +624     
+ Misses        686       62      -624     
Impacted Files Coverage Δ
...es/_internal/windows/component_descriptor_utils.py 100.00% <0.00%> (+5.88%) ⬆️
mbed_devices/_internal/detect_candidate_devices.py 100.00% <0.00%> (+25.00%) ⬆️
mbed_devices/_internal/windows/device_detector.py 72.22% <0.00%> (+72.22%) ⬆️
mbed_devices/_internal/utils/python_helpers.py 72.72% <0.00%> (+72.72%) ⬆️
..._devices/_internal/windows/usb_data_aggregation.py 76.92% <0.00%> (+76.92%) ⬆️
mbed_devices/_internal/windows/serial_port.py 84.21% <0.00%> (+84.21%) ⬆️
mbed_devices/_internal/windows/volume_set.py 86.95% <0.00%> (+86.95%) ⬆️
mbed_devices/_internal/windows/usb_hub.py 87.30% <0.00%> (+87.30%) ⬆️
...ndows/disk_partition_logical_disk_relationships.py 95.45% <0.00%> (+95.45%) ⬆️
mbed_devices/_internal/windows/disk_aggregation.py 95.60% <0.00%> (+95.60%) ⬆️
... and 6 more

@madchutney madchutney merged commit a5c9873 into master Feb 28, 2020
@madchutney madchutney deleted the fix_coverage branch February 28, 2020 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants