Skip to content

Conversation

li-ho
Copy link

@li-ho li-ho commented Sep 8, 2017

No description provided.

@li-ho li-ho closed this Sep 8, 2017
@li-ho
Copy link
Author

li-ho commented Sep 8, 2017

Leave a comment

@li-ho li-ho reopened this Sep 8, 2017
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brian beat me to it.

@theotherjimmy
Copy link
Contributor

@li-ho How could we confirm that these manufacture ids are correct?

@li-ho
Copy link
Author

li-ho commented Sep 18, 2017

ids themselves are correct. You can also confirm with @maclobdell and @sbrewer1

@maclobdell
Copy link
Contributor

maclobdell commented Sep 19, 2017

I can confirm that the IDs are correct on our system. Looks good to me.

@theotherjimmy - the mbed partner enablement team handles assigning unique IDs for new platforms and can confirm mbed-ls pull requests.

Thanks a lot for this pull request @li-ho!

@theotherjimmy
Copy link
Contributor

@maclobdell Thanks for confirmation.

All: Merging.

@theotherjimmy theotherjimmy merged commit a1aec61 into ARMmbed:master Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants