Fixing last unprotected registry access #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theotherjimmy
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #322.
The bug wasn't as bad as I thought. We already wrap every access to the Windows Registry with
try/exceptblocks for when/if they fail. This was the one and only access to the Windows Registry that wasn't protected. So this PR just adds thetry/exceptblock.I broke apart the
from_iterablecall to make sure we don't skip over the entire list of keys we're iterating over if an error is received in the middle of the list. This way it'll just move onto the next key. It also makes it a bit more clear what we're iterating over.FYI @c1728p9