Skip to content

Add new Maxim targets #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2018
Merged

Add new Maxim targets #328

merged 1 commit into from
Apr 18, 2018

Conversation

bentcooke
Copy link
Contributor

Adding the following Maxim targets and IDs:
0416 MAX32625PICO
0417 MAX32630MBED
0418 MAX32620FTHR
0419 MAX35103EVKIT2
0420 MAX32630HSP3

@theotherjimmy, could you please review?

@coveralls
Copy link

coveralls commented Apr 17, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 77.862% when pulling b4c56b1 on bentcooke:add_maxim_targets into 04e57d6 on ARMmbed:master.

bridadan
bridadan approved these changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look ok. In the DB MAX35103EVKIT2 and MAX32630MBED don't have logicalboards, guessing that's on purpose?

@bentcooke
Copy link
Contributor Author

Yes, those targets do not have platform pages yet.

@theotherjimmy theotherjimmy merged commit a8031d0 into ARMmbed:master Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bridadan bridadan bridadan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bentcooke @coveralls @bridadan @theotherjimmy