-
Notifications
You must be signed in to change notification settings - Fork 117
Mbed OS 5.11.0 #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Mbed OS 5.11.0 #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BLE_BatteryLevel/.mbedignore
Outdated
@@ -0,0 +1 @@ | |||
deprecated/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will be fixed in the 203
pan-
requested changes
Jan 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I compile for the DISCO, I get the following error:
Compile [100.0%]: BlueNrgHCIDriver.cpp
[Error] BlueNrgHCIDriver.cpp@587,44: cannot declare variable 'hci_driver' to be of abstract type 'ble::vendor::bluenrg::HCIDriver'
[ERROR] ./shields/TARGET_CORDIO_BLUENRG/BlueNrgHCIDriver.cpp: In function 'ble::vendor::cordio::CordioHCIDriver& ble_cordio_get_hci_driver()':
./shields/TARGET_CORDIO_BLUENRG/BlueNrgHCIDriver.cpp:587:44: error: cannot declare variable 'hci_driver' to be of abstract type 'ble::vendor::bluenrg::HCIDriver'
static ble::vendor::bluenrg::HCIDriver hci_driver(
^~~~~~~~~~
./shields/TARGET_CORDIO_BLUENRG/BlueNrgHCIDriver.cpp:41:7: note: because the following virtual functions are pure within 'ble::vendor::bluenrg::HCIDriver':
class HCIDriver : public cordio::CordioHCIDriver
^~~~~~~~~
In file included from ./mbed-os/features/FEATURE_BLE/targets/TARGET_CORDIO/CordioBLE.h:24:0,
from ./shields/TARGET_CORDIO_BLUENRG/BlueNrgHCIDriver.cpp:2:
./mbed-os/features/FEATURE_BLE/targets/TARGET_CORDIO/driver/CordioHCIDriver.h:81:29: note: virtual ble::vendor::cordio::buf_pool_desc_t ble::vendor::cordio::CordioHCIDriver::get_buffer_pool_description()
virtual buf_pool_desc_t get_buffer_pool_description() = 0;
^~~~~~~~~~~~~~~~~~~~~~~~~~~
pan-
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.