Skip to content
This repository was archived by the owner on Jun 8, 2021. It is now read-only.

Conversation

paul-szczepanek-arm
Copy link
Member

The netsocket example now includes the extra wifi elements so to cut down on duplication and maintenance this is being removed. Message links to the https://github.com/ARMmbed/mbed-os-example-sockets which is taking over.

@paul-szczepanek-arm
Copy link
Member Author

Wifi is now part of the sockets example

Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have you checked in the documentation and website for references to this example ?

I just found a reference at https://os.mbed.com/teams/ST/wiki/How-to-make-wifi-tests .

@donatieng Are you happy with this deprecation notice or do you expect something else ? The netsocket example covers all aspects of this example now.

@0xc0170
Copy link
Collaborator

0xc0170 commented Jan 11, 2021

@donatieng Are you happy with this deprecation notice or do you expect something else ? The netsocket example covers all aspects of this example now.

I'll create a story to document how to deprecate Mbed OS component, we should have this available and followed.

Copy link

@donatieng donatieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paul-szczepanek-arm Could you elaborate on the reason for deprecation, and maybe add a mention that the Socket examples have WiFi support? Plus maybe a warning icon? @0xc0170 would be worth using this example as a reference for deprecation.

README.md Outdated
@@ -1,4 +1,9 @@
![](./resources/official_armmbed_example_badge.png)
## this example has been deprecated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs capitalisation

Copy link

@donatieng donatieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Paul, LGTM
@0xc0170 are you happy with this as template?

@paul-szczepanek-arm paul-szczepanek-arm merged commit 08f5be1 into ARMmbed:development Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants