-
Notifications
You must be signed in to change notification settings - Fork 44
deprecate example #206
deprecate example #206
Conversation
Wifi is now part of the sockets example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, have you checked in the documentation and website for references to this example ?
I just found a reference at https://os.mbed.com/teams/ST/wiki/How-to-make-wifi-tests .
@donatieng Are you happy with this deprecation notice or do you expect something else ? The netsocket example covers all aspects of this example now.
I'll create a story to document how to deprecate Mbed OS component, we should have this available and followed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paul-szczepanek-arm Could you elaborate on the reason for deprecation, and maybe add a mention that the Socket examples have WiFi support? Plus maybe a warning icon? @0xc0170 would be worth using this example as a reference for deprecation.
README.md
Outdated
@@ -1,4 +1,9 @@ | |||
 | |||
## this example has been deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs capitalisation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Paul, LGTM
@0xc0170 are you happy with this as template?
The netsocket example now includes the extra wifi elements so to cut down on duplication and maintenance this is being removed. Message links to the https://github.com/ARMmbed/mbed-os-example-sockets which is taking over.