New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: QSPI support on DISCO_F769NI #8870

Closed
screamerbg opened this Issue Nov 26, 2018 · 17 comments

Comments

Projects
None yet
6 participants
@screamerbg
Copy link
Member

screamerbg commented Nov 26, 2018

Description

The DISCO_F769NI has quite large QSPI flash on board, but unfortunately the target support is lacking the QSPI "device_has" flag and also qspi_s definies in objects.h. Could you please add QSPI (and QSPIF feature) support for it?

CC @ARMmbed/team-st-mcd

Issue request type

[ ] Question
[X] Enhancement
[ ] Bug
@screamerbg

This comment has been minimized.

Copy link
Member

screamerbg commented Nov 26, 2018

Also cc @MarceloSalazar

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Nov 26, 2018

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

jeromecoutant commented Nov 27, 2018

Hi
Not so easy as DISCO_F769NI is using MX25L51245G which is not described yet in the test directory.
Thx

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

jeromecoutant commented Nov 27, 2018

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

jeromecoutant commented Nov 29, 2018

Current status with the above branch:

mbed test -t xxx -m xxx -v –n components-storage-blockdevice-component_qspif-tests-block_device-qspif

  • F469: OK
  • F746: OK
  • F769: FAILED (wrong device Id)
  • L475: OK
  • L476: OK
  • L496: FAILED (hard fault)

@screamerbg could you add QSPI expert in this issue discussion ?

Thx

@screamerbg

This comment has been minimized.

Copy link
Member

screamerbg commented Nov 29, 2018

@offirko

This comment has been minimized.

Copy link
Contributor

offirko commented Nov 29, 2018

@jeromecoutant - could you attach the full logs at the Jira or here , or send me by mail?
I do not have the F769 or L496 boards, and I cant find them at any of the CI sites either.

CC @maciejbocianski

@dannybenor

This comment has been minimized.

Copy link

dannybenor commented Nov 29, 2018

@jeromecoutant is F769 passing the HAL tests for QSPI?

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

jeromecoutant commented Nov 29, 2018

No, but DISCO_F769 has a new QSPI : MX25L51245G
which doesn't have a clean flash config configuration file...

@offirko

This comment has been minimized.

Copy link
Contributor

offirko commented Nov 29, 2018

@jeromecoutant - I believe qspif-blockdevice tests should only be run on the new targets after tests-mbed_hal-qspi tests are successful.

@offirko

This comment has been minimized.

Copy link
Contributor

offirko commented Dec 10, 2018

@screamerbg - I've received the DISCO_F769NI you sent. After making a small update to target hal and QSPIF BD fix the device works well. I'm not sure whether I can use this PR to deliver the changes.. or should I open a new PR?

@screamerbg

This comment has been minimized.

Copy link
Member

screamerbg commented Dec 10, 2018

@offirko Thanks for your work to enable this board. I think that it would be great if its part of this PR if @jeromecoutant doesn't object.

@offirko

This comment has been minimized.

Copy link
Contributor

offirko commented Dec 10, 2018

Note that after my changes QSPIFBlockDevice tests pass successfully, but 'tests-mbed_hal-qspi' still Fail.
This is something that I can not fix - I think it will require @jeromecoutant or @maciejbocianski to add specific setup for this board to the test.

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

jeromecoutant commented Dec 10, 2018

I think that it would be great if its part of this PR

There is no PR yet...
You can share a commit with your change, and I will open a PR
Thx @offirko

@maciejbocianski

This comment has been minimized.

Copy link
Member

maciejbocianski commented Dec 11, 2018

This target is not supported in mbed_hal-qspi test yet, I will add next week at the latest

@offirko

This comment has been minimized.

Copy link
Contributor

offirko commented Dec 11, 2018

Added PR #9057 which enables QSPIFBlockDevice to work properly with this board (once hal qspi test are supported)
#9057

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

jeromecoutant commented Dec 12, 2018

Hi
Status of
https://github.com/jeromecoutant/mbed/commits/DEV_QSPI_TEST

target platform_name test suite result elapsed_time (sec) copy_method
DISCO_F769NI-ARM DISCO_F769NI components-storage-blockdevice-component_qspif-tests-block_device-qspif OK 21.67 default
DISCO_F769NI-ARM DISCO_F769NI tests-mbed_hal-qspi FAIL 18.73 default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment