Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed cymetadata section from FUTURE_SEQUANA targets #10011

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
5 participants
@lrusinowicz
Copy link
Contributor

commented Mar 8, 2019

Description

This data, placed at physically not existing addresses (0x9xxxxxxx) was used
only by PSoC Programmer and KitProg2 and is no longer needed, but was causing
issues with standard hex file processing tools like srecord (srec_cat).

@0xc0170
This should remove nightly exporter failures (#9611).

Pull request type

[x] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

Removed cymetadata section from FUTURE_SEQUANA targets
This data, placed at physically not existing addresses (0x9xxxxxxx) was used
only by PSoC Programmer and KitProg2 and is no longer needed, but was causing
issues with standard hex file processing tools like srecord (srec_cat).
@0xc0170

0xc0170 approved these changes Mar 8, 2019

@orenc17

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

@lrusinowicz could you please also update the FUTURE_SEQUANA_PSA secure images with
python tools/psa/release.py -m FUTURE_SEQUANA_M0_PSA

@orenc17

orenc17 approved these changes Mar 8, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

@lrusinowicz could you please also update the FUTURE_SEQUANA_PSA secure images with
python tools/psa/release.py -m FUTURE_SEQUANA_M0_PSA

New PR or here? Just to know when to start CI for this one

@lrusinowicz

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

@orenc17
The script you've mentioned fails for me with

$ python tools/psa/release.py -m FUTURE_SEQUANA_M0_PSA
Traceback (most recent call last):
  File "tools/psa/release.py", line 163, in <module>
    main()
  File "tools/psa/release.py", line 159, in main
    build_psa_platform(target, toolchain)
  File "tools/psa/release.py", line 120, in build_psa_platform
    if _psa_backend(options.mcu) is 'TFM':
NameError: global name 'options' is not defined

I might not be on proper master commit for it. Anyway, as exporters should stop failing even with old images I would rather wait for merge and then update images from clean master.

@orenc17

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

@lrusinowicz this error is fixed in the latest master
you create the secure binaries in a later PR

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 8, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 8, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@ChiefBureaucraticOfficer
Copy link

left a comment

Meets criteria, fix for target to support PSA. Approved.

@0xc0170 0xc0170 merged commit c609d63 into ARMmbed:master Mar 8, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9169 cycles (+17 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.