Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed cymetadata section from FUTURE_SEQUANA targets #10011

Merged
merged 1 commit into from Mar 8, 2019

Conversation

lrusinowicz
Copy link
Contributor

Description

This data, placed at physically not existing addresses (0x9xxxxxxx) was used
only by PSoC Programmer and KitProg2 and is no longer needed, but was causing
issues with standard hex file processing tools like srecord (srec_cat).

@0xc0170
This should remove nightly exporter failures (#9611).

Pull request type

[x] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

This data, placed at physically not existing addresses (0x9xxxxxxx) was used
only by PSoC Programmer and KitProg2 and is no longer needed, but was causing
issues with standard hex file processing tools like srecord (srec_cat).
@orenc17
Copy link
Contributor

orenc17 commented Mar 8, 2019

@lrusinowicz could you please also update the FUTURE_SEQUANA_PSA secure images with
python tools/psa/release.py -m FUTURE_SEQUANA_M0_PSA

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 8, 2019

@lrusinowicz could you please also update the FUTURE_SEQUANA_PSA secure images with
python tools/psa/release.py -m FUTURE_SEQUANA_M0_PSA

New PR or here? Just to know when to start CI for this one

@lrusinowicz
Copy link
Contributor Author

@orenc17
The script you've mentioned fails for me with

$ python tools/psa/release.py -m FUTURE_SEQUANA_M0_PSA
Traceback (most recent call last):
  File "tools/psa/release.py", line 163, in <module>
    main()
  File "tools/psa/release.py", line 159, in main
    build_psa_platform(target, toolchain)
  File "tools/psa/release.py", line 120, in build_psa_platform
    if _psa_backend(options.mcu) is 'TFM':
NameError: global name 'options' is not defined

I might not be on proper master commit for it. Anyway, as exporters should stop failing even with old images I would rather wait for merge and then update images from clean master.

@orenc17
Copy link
Contributor

orenc17 commented Mar 8, 2019

@lrusinowicz this error is fixed in the latest master
you create the secure binaries in a later PR

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 8, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 8, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@ghost ghost added the PM_ACCEPTED label Mar 8, 2019
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meets criteria, fix for target to support PSA. Approved.

@0xc0170 0xc0170 merged commit c609d63 into ARMmbed:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants