Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Remove compile dependency of UARTSerial #10029

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
8 participants
@AriParkkila
Copy link
Contributor

commented Mar 11, 2019

Description

Fix issue #9848.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jarvte

Release Notes

@ciarmcom ciarmcom requested review from jarvte and ARMmbed/mbed-os-maintainers Mar 11, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

@AriParkkila, thank you for your changes.
@jarvte @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-wan Mar 11, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

The commit msg/title misleads a bit - we are not removing here the dependency rather adding the dependency requirement ?

@jarvte

jarvte approved these changes Mar 11, 2019

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

It is difficult to approve the change before #9850 patch proposal...

And I agree with Martin, you are not removing DEVICE_SERIAL dependency, you are adding some dependency?

@jeromecoutant
Copy link
Contributor

left a comment

You need to add also some DEVICE_INTERRUPTIN dependency

@0xc0170 0xc0170 added needs: work and removed needs: review labels Mar 12, 2019

@AriParkkila AriParkkila force-pushed the AriParkkila:cellular-device_serial branch to 903a6f2 Mar 13, 2019

@AriParkkila

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

@0xc0170 @jeromecoutant Changed commit message and added ifdef for DEVICE_INTERRUPTIN.

@AriParkkila AriParkkila changed the title Cellular: Remove DEVICE_SERIAL dependency Cellular: Remove compile dependency of UARTSerial Mar 13, 2019

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan Mar 14, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Mar 14, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

CI started

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

Build all OK, had to abort the rest of the pipeline to allow rc3 jobs in now. will restart once we can

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 14, 2019

Test run: FAILED

Summary: 4 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_greentea-test
  • jenkins-ci/mbed-os-ci_exporter
@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 16, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 16, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

possible ARMC6 license failure, restarting CI

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 17, 2019

Test run: FAILED

Summary: 2 of 13 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_exporter
@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

restarting cloud client test and exporters

@0xc0170 0xc0170 merged commit 4cf22b3 into ARMmbed:master Mar 18, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9148 cycles (-1042 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.