Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for reallocation memory fail in TMPM46B #10048

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
5 participants
@ganesh-ramachandran
Copy link
Contributor

commented Mar 12, 2019

Description

'gI2C_LTxData' is reallocated but the return value is not checked. If this fails it could lead to writing in uninitialized memory. Hence error check added if reallocation fails.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@janjongboom

Reference

PR #9987

@ciarmcom ciarmcom requested review from janjongboom, soramame21 and ARMmbed/mbed-os-maintainers Mar 12, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

@ganesh-ramachandran, thank you for your changes.
@soramame21 @janjongboom @ARMmbed/mbed-os-maintainers please review.

@janjongboom

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

I just found the issue, I don't feel comfortable reviewing HAL code.

@soramame21

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

the fix is fine.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

No more changes are expected there.

This was added to the rollup PR #10097 and it's currently in CI. If any new commit comes, please let us know immediately.

@0xc0170 0xc0170 merged commit c5ad72b into ARMmbed:master Mar 15, 2019

14 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9946 cycles (-737 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.