Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootloader support for Cypress PSA boards #10055

Merged

Conversation

Projects
None yet
8 participants
@yossi2le
Copy link
Contributor

commented Mar 12, 2019

Description

This PR adds bootloader support for the CY8CKIT_062_WIFI_BT_PSA and CY8CKIT_062_BLE boards in mbed-os.

This PR now depends on PR #10034 - V

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

Release target?

I dont think this is functionality change, rather target update?

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

Took a 10s lookover.

All of the files are PSOC-specific, thus this qualifies as a target update (aka, can come into a patch).

Release label udpated.

@amiraloosh

This comment has been minimized.

Copy link

commented Mar 12, 2019

This is required for the 5.12 release for the PSA support on the cypress board. can we target this to RC3 ?

@0xc0170 0xc0170 requested review from ChiefBureaucraticOfficer and ARMmbed/mbed-os-psa Mar 12, 2019

@0xc0170 0xc0170 changed the title Mbed-os changes to support Cypress PSA boards bootloader. Add bootloader support for Cypress PSA boards Mar 12, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

Fixed the title

@yossi2le yossi2le force-pushed the yossi2le:cypress-psa-and-future-sequana-bl-support branch Mar 12, 2019

@yossi2le

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

I have added another 2 linker script for the CY8CKIT_062_WIFI_BT_PSA target. Those two works great with default values but needed a fix for nondefault values.

@0xc0170 0xc0170 requested a review from ARMmbed/team-cypress Mar 13, 2019

@orenc17
Copy link
Contributor

left a comment

Please add remarks in linker script for MBED_APP_START & MBED_APP_SIZE.
@ARMmbed/team-cypress please review changes in:

  • gpio_api.c,
  • serial_api.c
  • post-binary hook

Everything else looks OK

Show resolved Hide resolved ...TARGET_Cypress/TARGET_PSOC6/TARGET_CY8CKIT_062_WIFI_BT_PSA/mbed_lib.json Outdated
@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

@orenc17 Does this need an additional review after recent changes?

@orenc17

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

No...just from Cypress

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 13, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

CI started while waiting for final reviews

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 13, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
@csd-cypress

This comment has been minimized.

Copy link

commented Mar 13, 2019

Hi,
We are not aware of this, and we are pursuing similar goals inside Cypress to enable bootloader support. As a first step do you have any design description so that we can compare your goals and approach to ours?

@orenc17

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

@ARMmbed/mbed-os-maintainers the failure seems to be related to SD, maybe a faulty SD card, could you run it again

@orenc17

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

@csd-cypress this is the inital support for pelion bootloader, to allow FW upgrade for the application core.
your HW bootloader will be integrated in the near future.

"name": "bootloader_CY8CKIT_062_BLE",
"target_overrides": {
"*": {
"target.app_offset": "0x0A400",

This comment has been minimized.

Copy link
@vmedcy

vmedcy Mar 13, 2019

Contributor

Why these target attributes are added to mbed_lib.json instead of top-level targets.json?

This comment has been minimized.

Copy link
@orenc17

orenc17 Mar 13, 2019

Contributor

this is a bootloader property.
if a user decide not to use bootloader we don't need this config

@@ -0,0 +1,49 @@
Permissive Binary License

This comment has been minimized.

Copy link
@vmedcy

vmedcy Mar 13, 2019

Contributor

Why the LICENSE is added to top-level target directory? The PBL only applies to the hex files, not .c/.h sources.
Can you move the hex files to device/hex, together with existing hex files covered by binary license?

This comment has been minimized.

Copy link
@vmedcy

vmedcy Mar 13, 2019

Contributor

Sorry I just figured out this is features/FEATURE_BOOTLOADER/targets/TARGET_Cypress, not targets/TARGET_Cypress.

Show resolved Hide resolved targets/targets.json Outdated
Show resolved Hide resolved tools/arm_pack_manager/index.json
Show resolved Hide resolved tools/arm_pack_manager/index.json
Show resolved Hide resolved targets/targets.json Outdated
Show resolved Hide resolved targets/targets.json Outdated
@csd-cypress

This comment has been minimized.

Copy link

commented Mar 13, 2019

@csd-cypress this is the inital support for pelion bootloader, to allow FW upgrade for the application core.
your HW bootloader will be integrated in the near future.

ok understood, it will still be good to understand more about the pelion bootloader so that we can integrate it to our bootloader effort. Is it mcuboot based? Do you expect it to come after/before/in-replacement of our bootloader? How will it integrate verification of signed images with the PSoC64 root-of-trust?
Also when you say HW bootloader will be integrated in the near future - which HW bootloader and integrated by whom?

@cmonr cmonr removed the needs: CI label Mar 13, 2019

@yossi2le yossi2le force-pushed the yossi2le:cypress-psa-and-future-sequana-bl-support branch Mar 14, 2019

@yossi2le

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

Important update: After the last update, this PR now depends on PR #10034

@yossi2le yossi2le force-pushed the yossi2le:cypress-psa-and-future-sequana-bl-support branch Mar 14, 2019

@yossi2le yossi2le force-pushed the yossi2le:cypress-psa-and-future-sequana-bl-support branch to 0880f90 Mar 14, 2019

@yossi2le

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

Rebase on top of master with all preceding PRs merged.
Please start CI

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

CI started

@yossi2le

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

@csd-cypress this is the inital support for pelion bootloader, to allow FW upgrade for the application core.
your HW bootloader will be integrated in the near future.

ok understood, it will still be good to understand more about the pelion bootloader so that we can integrate it to our bootloader effort. Is it mcuboot based? Do you expect it to come after/before/in-replacement of our bootloader? How will it integrate verification of signed images with the PSoC64 root-of-trust?
Also when you say HW bootloader will be integrated in the near future - which HW bootloader and integrated by whom?

You can find our bootloader sources and some docs at https://github.com/ARMmbed/mbed-bootloader-internal

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

@yossi2le Above url is internal, not available publicly

@yossi2le

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

@yossi2le Above url is internal, not available publicly

I didn't know that. do we have a link for a bootloader external? otherwise, I should delete my replay.

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 14, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr merged commit 529aef9 into ARMmbed:master Mar 14, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10217 cycles (+552 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.