Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed PSoC6 SystemInit Workaround for ARM compiler #10073

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
6 participants
@morser499
Copy link

commented Mar 13, 2019

Description

Removed PSoC6 SystemInit declaration as constructor for ARM compiler

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

@morser499, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Mar 13, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

MCU_PSOC6 still has ARMC5 defined - this fix is still needed or not?

@orenc17
Copy link
Contributor

left a comment

Thank you

@morser499

This comment has been minimized.

Copy link
Author

commented Mar 13, 2019

This merge cleans up a hack in our code. It has nothing to do with ARMC5 vs ARM6. We expect to be migrating our targets to ARM6 hopefully tomorrow.

@cmonr

cmonr approved these changes Mar 13, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

No more changes are expected there.

This was added to the rollup PR #10097 and it's currently in CI. If any new commit comes, please let us know immediately.

@0xc0170 0xc0170 merged commit 2af3a82 into ARMmbed:master Mar 15, 2019

14 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9096 cycles (-1094 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Mar 15, 2019

@morser499 morser499 deleted the morser499:cy-mbed-os-5.12.0-ARM-compiler branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.