Skip to content

Removed PSoC6 SystemInit Workaround for ARM compiler #10073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2019
Merged

Removed PSoC6 SystemInit Workaround for ARM compiler #10073

merged 1 commit into from
Mar 15, 2019

Conversation

morser499
Copy link

Description

Removed PSoC6 SystemInit declaration as constructor for ARM compiler

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom
Copy link
Member

@morser499, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team March 13, 2019 02:00
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 13, 2019

MCU_PSOC6 still has ARMC5 defined - this fix is still needed or not?

orenc17
orenc17 approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@orenc17 orenc17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@morser499
Copy link
Author

This merge cleans up a hack in our code. It has nothing to do with ARMC5 vs ARM6. We expect to be migrating our targets to ARM6 hopefully tomorrow.

@0xc0170 0xc0170 mentioned this pull request Mar 14, 2019
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 14, 2019

No more changes are expected there.

This was added to the rollup PR #10097 and it's currently in CI. If any new commit comes, please let us know immediately.

@0xc0170 0xc0170 merged commit 2af3a82 into ARMmbed:master Mar 15, 2019
@0xc0170 0xc0170 removed the needs: CI label Mar 15, 2019
@morser499 morser499 deleted the cy-mbed-os-5.12.0-ARM-compiler branch March 15, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@orenc17 orenc17 orenc17 approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.1 rollup PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@morser499 @ciarmcom @0xc0170 @cmonr @orenc17