Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with PWM not being freed when the object is destroyed #10074

Merged
merged 1 commit into from Mar 27, 2019

Conversation

Projects
None yet
8 participants
@morser499
Copy link

commented Mar 13, 2019

Description

Fixed issue with PWM not being freed when the object is destroyed. This caused the PWM to continue running after the destructor was called and it could cause a crash if another PWM was initialized.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

@morser499, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 13, 2019

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-hal Mar 13, 2019

@@ -68,6 +68,7 @@ class PwmOut {
~PwmOut()
{
core_util_critical_section_enter();
pwmout_free(&_pwm);

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Mar 13, 2019

Member

@ARMmbed/mbed-os-hal what was the reason not having this earlier ? I recall some discussions in some other drivers around definition of _free and implications for the rest of targets with change like this one.

This comment has been minimized.

Copy link
@c1728p9

c1728p9 Mar 18, 2019

Contributor

I thought it was because not all the targets had this function. If this is the case then CI should catch any problems.

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Mar 20, 2019

Member

That is it !

We do not have 100 percent coverage in CI, I am thinking to be on safer side to have this on 5.13 rather - to keep this on master for some time.

@cmonr

cmonr approved these changes Mar 18, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 19, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 19, 2019

@0xc0170
Copy link
Member

left a comment

One small change request

* destructor. The pwmout_init handles multiple calls of constructor.
*/
#if DEVICE_SLEEP && DEVICE_LPTICKER
if (!Cy_SysPm_UnregisterCallback(&obj->pm_callback_handler))

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Mar 20, 2019

Member

Can you fix the style { on the same line (entire file is consistent)

This comment has been minimized.

Copy link
@morser499

@0xc0170 0xc0170 added needs: work and removed ready for merge labels Mar 20, 2019

@morser499 morser499 force-pushed the morser499:cy-mbed-os-5.12.0-pwm-free branch from 8aaf145 to 51a4713 Mar 21, 2019

@cmonr cmonr added needs: CI and removed needs: work labels Mar 25, 2019

@cmonr cmonr requested a review from 0xc0170 Mar 25, 2019

Change addressed.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 26, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019

Merge pull request ARMmbed#10074 from morser499/cy-mbed-os-5.12.0-pwm…
…-free

Fixed issue with PWM not being freed when the object is destroyed

@cmonr cmonr merged commit 0395150 into ARMmbed:master Mar 27, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9129 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.