Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: Fix ble gattserver autorization list registration #10094

Merged

Conversation

Projects
None yet
7 participants
@desmond-blue
Copy link
Contributor

commented Mar 14, 2019

Description

This is for #10028, GattServer maintains an authorization list which is registered by attribute permission check, UPDATE_PROPERTIES which equals NOTIFY_PROPERTY | INDICATE_PROPERTY is not a correct permission check.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@desmond-blue desmond-blue changed the title Fix ble gattserver autorization list registration BLE: Fix ble gattserver autorization list registration Mar 14, 2019

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 14, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

@desmond-blue, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@pan-
Copy link
Member

left a comment

I'm afraid that change isn't correct. We need to cache characteristic that send update as we consult the getUpdateSecurityRequirement latter.

@cmonr cmonr added needs: work and removed needs: review labels Mar 15, 2019

@desmond-blue desmond-blue force-pushed the desmond-blue:fix_ble_gattserver_autorization_list branch to 196a766 Mar 15, 2019

@desmond-blue

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

Hi @pan- , got it, then I believe the condition check for update properties should be changed from
attribute_it->permissions & UPDATE_PROPERTIES
to
properties & UPDATE_PROPERTIES

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@desmond-blue Any updates on this pr ?

@desmond-blue

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

@pan- I've done some changes on original commit, could you check if it's good? Thanks.

@cmonr cmonr added needs: review and removed needs: work labels Mar 28, 2019

@cmonr cmonr requested a review from pan- Mar 28, 2019

@cmonr

cmonr approved these changes Mar 28, 2019

@pan-

pan- approved these changes Mar 28, 2019

Copy link
Member

left a comment

@desmond-blue thanks.

@cmonr cmonr added needs: CI and removed needs: review labels Mar 28, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 29, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
@alekla01

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

restarted jenkins-ci/mbed-os-ci_greentea-test

@adbridge adbridge added ready for merge and removed needs: CI labels Mar 29, 2019

@cmonr cmonr merged commit eef1b48 into ARMmbed:master Mar 29, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9197 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.