Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for LoRaWAN downlink sequence counter rollover #10154

Merged
merged 2 commits into from Mar 27, 2019

Conversation

Projects
None yet
7 participants
@itziardelatorre
Copy link
Contributor

commented Mar 19, 2019

Description

Fix issue related to downlink sequence counter rollover in LoRaWAN.
For the test, the downlink sequence counter of the downlink messages has been incremented by 1600 (< MAX_FCNT_GAP) several times. For example, until 64005 and following situation was shown:

Downlink sequence counter increased to 64005 (by 1600 steps)
The radio module accepts this, as expected.
After that, downlink sequence counter increased to 65536 (rollover for 32 bits sequence counter)
The radio module rejects this frame
With the change everything works fine.

Pull request type

[ x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@hasnainvirk
Copy link
Contributor

left a comment

Looks great. Thanks.

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 19, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

@itziardelatorre, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@cmonr

cmonr approved these changes Mar 19, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

CI started

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

Too early, aborted, will restart once other rc4 fixes complete.

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 22, 2019

Test run: FAILED

Summary: 8 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-ARMC6
  • jenkins-ci/mbed-os-ci_mbed2-build-ARMC5
  • jenkins-ci/mbed-os-ci_build-ARMC5
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR8
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARMC6
  • jenkins-ci/mbed-os-ci_build-IAR8
@hasnainvirk

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

@0xc0170 Failures seem to be unrelated to the PR. Is it possible to kick start the CI again ?

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 24, 2019

restarting CI

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 24, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019

Merge pull request ARMmbed#10154 from itziardelatorre/itziar
Fix for LoRaWAN downlink sequence counter rollover

@cmonr cmonr merged commit eff1580 into ARMmbed:master Mar 27, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9150 cycles (-687 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.