Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compilation error in LWIPStack class if lwip tcp is disabled. #10190

Merged
merged 1 commit into from Mar 27, 2019

Conversation

Projects
None yet
8 participants
@tymoteuszblochmobica
Copy link
Contributor

commented Mar 21, 2019

Description

LWIP setsockopt member has now #if LWIP_TCP to prevent using of TCP PCB if TCP is disabled.

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@tymoteuszblochmobica

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

@SeppoTakalo please review

@tymoteuszblochmobica

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

@mikaleppanen please review

@tymoteuszblochmobica

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

@kjbracey-arm please review

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 21, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

@tymoteuszblochmobica, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

@tymoteuszblochmobica Use Reviewers section in the PR to request reviews (will be added automatically to PR reviewers list)

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 24, 2019

starting CI

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 24, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@alekla01

This comment has been minimized.

Copy link
Contributor

commented Mar 24, 2019

restarted jenkins-ci/exporter

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019

Merge pull request ARMmbed#10190 from tymoteuszblochmobica/fixtcp
Fixed compilation error in LWIPStack class if lwip tcp is disabled.

@cmonr cmonr merged commit e8e6ad4 into ARMmbed:master Mar 27, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9864 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 27, 2019

@tymoteuszblochmobica tymoteuszblochmobica deleted the tymoteuszblochmobica:fixtcp branch Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.