Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail/MemoryPool: blocking alloc #10225

Merged
merged 2 commits into from Apr 12, 2019

Conversation

Projects
None yet
7 participants
@kjbracey-arm
Copy link
Contributor

commented Mar 26, 2019

Description

Mail and MemoryPool did not permit access to the blocking form of allocation available in CMSIS-RTOS 2 - give them new blocking methods.

Fixes #10216.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Release Notes

  • Mail and MemoryPool now provide blocking forms of alloc calls that can sleep the thread until a memory block is available.

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:memorypool_blocking_alloc branch 2 times, most recently from 8d4000e to 86e177f Mar 26, 2019

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 26, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

@kjbracey-arm, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:memorypool_blocking_alloc branch from 4a6741c to 8f1dcff Mar 26, 2019

}

/** Allocate a memory block from a memory pool, optionally blocking, and set memory block to zero.
@return address of the allocated memory block or NULL in case of no memory available.

This comment has been minimized.

Copy link
@desowin

desowin Mar 26, 2019

Contributor

I think it would be good to add the description of millisec parameter here as well
@param millisec timeout value (osWaitForever to wait forever)

kjbracey-arm added some commits Mar 26, 2019

Mail/MemoryPool: blocking alloc
Mail and MemoryPool did not permit access to the blocking form of
allocation available in CMSIS-RTOS 2 - give them new blocking methods.

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:memorypool_blocking_alloc branch from 8f1dcff to b8d90fb Mar 26, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

@ARMmbed/mbed-os-core Would anyone fancy a look?

@deepikabhavnani
Copy link
Contributor

left a comment

Looks good to me 👍

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 10, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 10, 2019

@cmonr cmonr merged commit b1e48db into ARMmbed:master Apr 12, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9158 cycles (+32 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.