Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cellular: valgrind defect fix #10269

Merged
merged 1 commit into from Apr 3, 2019

Conversation

Projects
None yet
8 participants
@TeemuKultala
Copy link
Contributor

commented Mar 29, 2019

Description

This fixes cellular Valgrind memtest defects. Tested with unit tests. cellulardevicetest.cpp valgrind problem is going to be addressed separately

Pull request type

[ X ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jarvte @mirelachirica

@jarvte

jarvte approved these changes Mar 29, 2019

@ciarmcom ciarmcom requested review from jarvte, mirelachirica and ARMmbed/mbed-os-maintainers Mar 29, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

@cmonr

cmonr approved these changes Mar 29, 2019

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2019

@jarvte could you please re-approve (your approval seems to have been cleared, although I don't see any subsequent changes)

@jarvte

jarvte approved these changes Mar 31, 2019

@0xc0170
Copy link
Member

left a comment

the commit message is not sufficient for this fix. please add more details - what issues is this fixing and how. The only relevant change I can see in the at_cellulardevicetest.cpp but the rest of changes are not clear to me what they are fixing.

@0xc0170 0xc0170 added needs: work and removed needs: review labels Apr 1, 2019

@amq

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

How did you run valgrind?

Teemu Kultala
cellular: valgrind defect fix
at_cellulardevicetest.cpp: fix potential memory leak
at_cellularsmstest.cpp: fix potential memory leak, uninitialized memory conditional
athandlertest.cpp: fix potential memory leak, uninitialized memory conditional,
uninitialized memory read
ATHandler_stub.cpp, ATHandler_stub.h: fix potential memory leak, uninitialized memory conditional
@TeemuKultala

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

Discovered valgrind defect types for each file added to the commit message. How the defects are fixed can be seen by inspecting the changes. Valgrind test was ran this way:
./UNITTESTS/mbed_unittest.py -d --compile --coverage both
cd build
ctest -T memcheck

After this the report is available in Testing/current_date_time folder

@0xc0170

0xc0170 approved these changes Apr 3, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Apr 3, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 3, 2019

Test run: SUCCESS

Summary: 1 of 1 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 3, 2019

@0xc0170 0xc0170 merged commit 2369c12 into ARMmbed:master Apr 3, 2019

16 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9151 cycles (-1224 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Apr 3, 2019

@TeemuKultala TeemuKultala deleted the TeemuKultala:cellular_valgrind_fix branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.