Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE SimpleAdvertisingBuilder moved functions out of mbed_assert calls #10270

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
8 participants
@marcemmers
Copy link
Contributor

commented Mar 29, 2019

Description

I had an issue where advertising stopped working in release mode when using this code:

    ble::AdvertisingDataSimpleBuilder<0x1F> advertisingBuilder;

    advertisingBuilder.setFlags( GapAdvertisingData::BREDR_NOT_SUPPORTED | GapAdvertisingData::LE_GENERAL_DISCOVERABLE );
    advertisingBuilder.setName( DEVICE_NAME );
    advertisingBuilder.setLocalService( SERVICE_UUID, false );

Found out that the functions setFlags and setName were optimized away. This is caused by the functions are internally calling functions inside an mbed_assert call resulting in a nop when NDEBUG is defined.

I moved the function calls out of the mbed_assert calls and checked the result later.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 29, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

@marcemmers, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@cmonr

cmonr approved these changes Mar 29, 2019

Copy link
Contributor

left a comment

Nice find!

@cmonr cmonr added needs: CI and removed needs: review labels Mar 29, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 30, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@pan-

pan- approved these changes Apr 1, 2019

Copy link
Member

left a comment

Thanks for the fixes.

@0xc0170 0xc0170 merged commit 1b4f6ae into ARMmbed:master Apr 1, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9151 cycles (-717 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.