Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: force mandatory services to have lowest handles #10302

Merged
merged 1 commit into from Apr 4, 2019

Conversation

Projects
None yet
6 participants
@paul-szczepanek-arm
Copy link
Member

commented Apr 3, 2019

Description

Mandatory services can be added before or after user added services. The nordic monitor application assumes they are the first service discovered and fail if they are not. This fix makes sure the mandatory service is added before any user service.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@pan-

@pan-

pan- approved these changes Apr 3, 2019

Copy link
Member

left a comment

As much as I disliked the behaviour exposed by the services (instantiation before initialisation of the GattServer...) there's not much we can do about it now. Thanks for the workaround @paul-szczepanek-arm

@ciarmcom ciarmcom requested a review from pan- Apr 3, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

@paul-szczepanek-arm, thank you for your changes.
@pan- @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Apr 3, 2019

@0xc0170

0xc0170 approved these changes Apr 3, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 3, 2019

@pan-

pan- approved these changes Apr 3, 2019

Copy link
Member

left a comment

The bot is too slow for us . Approved again.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

The bot is too slow for us . Approved again.

It should not rewrite it, will be fixed

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 3, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Apr 4, 2019

@0xc0170 0xc0170 merged commit 46dc15e into ARMmbed:master Apr 4, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9976 cycles (+865 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.