Cellular: Fix deleting of state machine to correct class #10338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jarvte, thank you for your changes. |
AriParkkila
suggested changes
Apr 8, 2019
| @@ -116,9 +117,13 @@ nsapi_error_t CellularDevice::attach_to_network() | |||
|
|
|||
| nsapi_error_t CellularDevice::create_state_machine() | |||
| { | |||
| _nw = open_network(_fh); | |||
There was a problem hiding this comment.
This could be inside if (!_state_machine) and it should also be closed when _stat_machine is deleted.
There was a problem hiding this comment.
Fixed. _state_machine is deleted in destructor and inheriting class will close all the opened interfaces in it's destructor.
jarvte
force-pushed
the
fix_deleting_of_stm
branch
from
c193498 to
fe5f978
Compare
|
force-pushed review changes: moved opening of network interface under the if state machine. |
AriParkkila
approved these changes
Apr 8, 2019
cmonr
approved these changes
Apr 8, 2019
|
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
State machine was deleted in different class than it was created. Now it's deleted in correct place.
Pull request type
Reviewers
@AriParkkila
Release Notes