Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upCellular: Fix deleting of state machine to correct class #10338
+39
−54
Conversation
ciarmcom
requested review from
AriParkkila and
ARMmbed/mbed-os-maintainers
Apr 8, 2019
This comment has been minimized.
This comment has been minimized.
|
@jarvte, thank you for your changes. |
ciarmcom
added
the
needs: review
label
Apr 8, 2019
AriParkkila
suggested changes
Apr 8, 2019
| @@ -116,9 +117,13 @@ nsapi_error_t CellularDevice::attach_to_network() | |||
|
|
|||
| nsapi_error_t CellularDevice::create_state_machine() | |||
| { | |||
| _nw = open_network(_fh); | |||
This comment has been minimized.
This comment has been minimized.
AriParkkila
Apr 8, 2019
Contributor
This could be inside if (!_state_machine) and it should also be closed when _stat_machine is deleted.
This comment has been minimized.
This comment has been minimized.
jarvte
Apr 8, 2019
Author
Contributor
Fixed. _state_machine is deleted in destructor and inheriting class will close all the opened interfaces in it's destructor.
0xc0170
added
needs: work
and removed
needs: review
labels
Apr 8, 2019
jarvte
force-pushed the
jarvte:fix_deleting_of_stm
branch
from
c193498
to
fe5f978
Apr 8, 2019
This comment has been minimized.
This comment has been minimized.
|
force-pushed review changes: moved opening of network interface under the if state machine. |
AriParkkila
approved these changes
Apr 8, 2019
0xc0170
added
needs: review
and removed
needs: work
labels
Apr 8, 2019
cmonr
approved these changes
Apr 8, 2019
cmonr
added
needs: CI
release-version: 5.12.2
and removed
needs: review
labels
Apr 8, 2019
This comment has been minimized.
This comment has been minimized.
|
CI started |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Apr 9, 2019
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
cmonr
added
ready for merge
and removed
needs: CI
labels
Apr 9, 2019
0xc0170
merged commit a59ba20
into
ARMmbed:master
Apr 9, 2019
28 checks passed
continuous-integration/jenkins/pr-head
This commit looks good
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
jenkins-ci/build-ARMC5
Success
Details
jenkins-ci/build-ARMC6
Success
Details
jenkins-ci/build-GCC_ARM
Success
Details
jenkins-ci/build-IAR8
Success
Details
jenkins-ci/cloud-client-test
Success
Details
jenkins-ci/dynamic-memory-usage
RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter
Success
Details
jenkins-ci/greentea-test
Success
Details
jenkins-ci/mbed2-build-ARMC5
Success
Details
jenkins-ci/mbed2-build-ARMC6
Success
Details
jenkins-ci/mbed2-build-GCC_ARM
Success
Details
jenkins-ci/mbed2-build-IAR8
Success
Details
jenkins-ci/unittests
Success
Details
travis-ci/astyle
Local astyle testing has passed
Details
travis-ci/docs
Local docs testing has passed
Details
travis-ci/doxy-spellcheck
Local doxy-spellcheck testing has passed
Details
travis-ci/events
Passed, runtime is 10336 cycles (+325 cycles)
Details
travis-ci/gitattributestest
Local gitattributestest testing has passed
Details
travis-ci/include_check
Local include_check testing has passed
Details
travis-ci/licence_check
Local licence_check testing has passed
Details
travis-ci/littlefs
Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen
Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7
Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5
Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6
Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7
Local tools-py3.7 testing has passed
Details
0xc0170
removed
the
ready for merge
label
Apr 9, 2019
jarvte
deleted the
jarvte:fix_deleting_of_stm
branch
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jarvte commentedApr 8, 2019
Description
State machine was deleted in different class than it was created. Now it's deleted in correct place.
Pull request type
Reviewers
@AriParkkila
Release Notes