Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Fix deleting of state machine to correct class #10338

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
6 participants
@jarvte
Copy link
Contributor

commented Apr 8, 2019

Description

State machine was deleted in different class than it was created. Now it's deleted in correct place.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AriParkkila

Release Notes

@ciarmcom ciarmcom requested review from AriParkkila and ARMmbed/mbed-os-maintainers Apr 8, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

@jarvte, thank you for your changes.
@AriParkkila @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@@ -116,9 +117,13 @@ nsapi_error_t CellularDevice::attach_to_network()

nsapi_error_t CellularDevice::create_state_machine()
{
_nw = open_network(_fh);

This comment has been minimized.

Copy link
@AriParkkila

AriParkkila Apr 8, 2019

Contributor

This could be inside if (!_state_machine) and it should also be closed when _stat_machine is deleted.

This comment has been minimized.

Copy link
@jarvte

jarvte Apr 8, 2019

Author Contributor

Fixed. _state_machine is deleted in destructor and inheriting class will close all the opened interfaces in it's destructor.

@0xc0170 0xc0170 added needs: work and removed needs: review labels Apr 8, 2019

@jarvte jarvte force-pushed the jarvte:fix_deleting_of_stm branch from c193498 to fe5f978 Apr 8, 2019

@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

force-pushed review changes: moved opening of network interface under the if state machine.

@0xc0170 0xc0170 added needs: review and removed needs: work labels Apr 8, 2019

@cmonr

cmonr approved these changes Apr 8, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 9, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Apr 9, 2019

@0xc0170 0xc0170 merged commit a59ba20 into ARMmbed:master Apr 9, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10336 cycles (+325 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Apr 9, 2019

@jarvte jarvte deleted the jarvte:fix_deleting_of_stm branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.