-
Notifications
You must be signed in to change notification settings - Fork 3k
Cellular: Fix deleting of state machine to correct class #10338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jarvte, thank you for your changes. |
@@ -116,9 +117,13 @@ nsapi_error_t CellularDevice::attach_to_network() | |||
|
|||
nsapi_error_t CellularDevice::create_state_machine() | |||
{ | |||
_nw = open_network(_fh); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be inside if (!_state_machine)
and it should also be closed when _stat_machine
is deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. _state_machine is deleted in destructor and inheriting class will close all the opened interfaces in it's destructor.
c193498
to
fe5f978
Compare
force-pushed review changes: moved opening of network interface under the if state machine. |
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
Description
State machine was deleted in different class than it was created. Now it's deleted in correct place.
Pull request type
Reviewers
@AriParkkila
Release Notes