Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of supported targets for mbed 2 builds #10347

Merged
merged 2 commits into from Apr 10, 2019

Conversation

Projects
None yet
7 participants
@bridadan
Copy link
Contributor

commented Apr 8, 2019

Description

Fix #10107.

This should get Mbed 2 builds going again with ARMC6. The uARM logic doesn't seem to be 100%, but honestly I'm not really sure what the expected behavior is for it.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@jeromecoutant

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Apr 8, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

@bridadan, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 8, 2019

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-ARMC5

@0xc0170 0xc0170 requested a review from jeromecoutant Apr 9, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Looking at the build failures, only SAM targets failed Mbed 2 ARMC5 build. Please review

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Apr 9, 2019

@0xc0170

0xc0170 approved these changes Apr 9, 2019

@bridadan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

Looks like those targets aren't compatible with ARMC6, so I moved them to ARMC5 only.

@cmonr cmonr added needs: review and removed needs: work labels Apr 9, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

CI started

@cmonr cmonr added needs: CI and removed needs: review labels Apr 9, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 9, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
Force SAMD21 and SAMR21 targets to ARMC5 due to incompatibility.
The hal code for this target uses "const volatile" types inside of
structs, which are non-trivially copyable in clang (used by ARMC6). This
causes the build to fail.

Here's the commit that changed this in clang:
llvm-mirror/clang@a3d727b

It seems this was reverteed some time ago in clang, but ARMC6 may not
be up to date.

@bridadan bridadan force-pushed the bridadan:allow_mbed_2_builds branch from ec49777 to 11775ef Apr 9, 2019

@bridadan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

Oh jeez, I missed one. Pushed a fix.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

Oh jeez, I missed one. Pushed a fix.

rabble rabble rabble

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 9, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@cmonr cmonr removed the needs: CI label Apr 10, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

@jeromecoutant Mind taking a look at this?

@0xc0170 0xc0170 merged commit bb0baee into ARMmbed:master Apr 10, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9186 cycles (-618 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.