Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse M33 + GCC_ARM map files #10348

Merged
merged 3 commits into from Apr 10, 2019

Conversation

Projects
None yet
6 participants
@theotherjimmy
Copy link
Contributor

commented Apr 8, 2019

Description

Turns out that under certain circumstances, GCC_ARM will emit
whitespace-delimited text in map files. Before this PR, Memap's
GCC_ARM map file parsing logic assumes that sections assumes
that the sections always start the string. This PR allows the
sections to be prefixed by whitespace.

Fixes #10109

Note for reviewers: the first commit cleans up lint warnings and
the second commit fixes the bug.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Apr 8, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

@theotherjimmy, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-tools Apr 8, 2019

@bridadan

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

Changes look fine, but you get to make travis happy now :)

@0xc0170

0xc0170 approved these changes Apr 9, 2019

@0xc0170 0xc0170 added needs: work and removed needs: review labels Apr 9, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 9, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 8e02592 into ARMmbed:master Apr 10, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(-32 bytes) RAM(-4 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9872 cycles (+708 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.