Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to LWIP 2.1.2 #10353

Merged
merged 2 commits into from Apr 15, 2019

Conversation

@tymoteuszblochmobica
Copy link
Contributor

commented Apr 9, 2019

Description

Latest LWIP 2.1.2 with necessary patches integrated with MbebOS

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@mikaleppanen
@kjbracey-arm

Release Notes

Latest LWIP 2.1.2 released is now integrated with MbedOS.
New LWIP release has improvements in following areas:

-IP4 routing
-IP6 scopes and zones
-dhcp6
-nd6
-tcp
-Sockets
-Binding network interfaces to sockets

LWIP changelog contains detailed changes

MbedOS dedicated patches were applied to new LWIP.
Multihoming was refactored due to new socket-interface bind implementation.

@ciarmcom ciarmcom requested review from kjbracey-arm, mikaleppanen, SeppoTakalo and ARMmbed/mbed-os-maintainers Apr 9, 2019

@ciarmcom

This comment has been minimized.

@tymoteuszblochmobica tymoteuszblochmobica force-pushed the tymoteuszblochmobica:multihoming branch from 8b243a4 to 822e51f Apr 9, 2019

@0xc0170
Copy link
Member

left a comment

Second commit is only about "Multihoming was refactored due to new socket-interface bind implementation." ?
The commit changes lot of files (adding parameters, new functions) so not certain what is this refactor doing - would it make sense to add there more details or split ?

@michalpasztamobica

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

@0xc0170 , I think the most important reviews are still to come from @mikaleppanen , @kjbracey-arm and @SeppoTakalo . Please do not merge until at least one of them approves...

Regarding the commit split, the idea was the following:

  1. Commit the actual new LWIP.
  2. Get multihoming working again.

The second commit message body is "Multihoming fixed according to new LWIP implementation." Perhaps this should become the title of the commit message instead of just being its body?

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

@0xc0170 , I think the most important reviews are still to come from @mikaleppanen , @kjbracey-arm and @SeppoTakalo . Please do not merge until at least one of them approves...

👍

The second commit message body is "Multihoming fixed according to new LWIP implementation." Perhaps this should become the title of the commit message instead of just being its body?

Could be. Let other reviewers look at this as well

@tymoteuszblochmobica tymoteuszblochmobica force-pushed the tymoteuszblochmobica:multihoming branch from 822e51f to 3512caa Apr 10, 2019

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

Looks OK.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 11, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 11, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 11, 2019

@cmonr cmonr closed this Apr 12, 2019

@cmonr cmonr removed the ready for merge label Apr 12, 2019

@cmonr cmonr reopened this Apr 12, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

Info: This PR has now been rebased.

Travis CI did not want to start, so I gave the PR an updated sha to generate the webhook.

@cmonr cmonr force-pushed the tymoteuszblochmobica:multihoming branch from 3512caa to 42b5680 Apr 12, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

CI started

@cmonr cmonr added the needs: CI label Apr 12, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 12, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Exporters restarted - internal symlink error

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 12, 2019

@0xc0170 0xc0170 merged commit b0ba3d3 into ARMmbed:master Apr 15, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+4 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9160 cycles (-1206 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.