Cellular: Fix to delete PDP context on disconnect #10375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AriParkkila, thank you for your changes. |
jarvte
approved these changes
Apr 12, 2019
0xc0170
approved these changes
Apr 12, 2019
|
CI started |
| if (_new_context_set) { | ||
| delete_current_context(); | ||
| } | ||
| _cid = -1; |
There was a problem hiding this comment.
delete_current_context() sets _cid to -1 only in successful case. What is the meaning of this line?
There was a problem hiding this comment.
Disconnect must be set _cid = -1 to not expect any _cid to be valid/preferred on the next connect request, even when we did not create that _cid ourselves.
| if (_new_context_set) { | ||
| delete_current_context(); | ||
| } | ||
| _cid = -1; |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
mirelachirica
approved these changes
Apr 15, 2019
|
@AnttiKauppila Are there any requests for changes left ? |
AnttiKauppila
approved these changes
Apr 16, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Delete cellular PDP context on
NetworkInterface::disconnectif one was created while connecting.Pull request type
Reviewers
@jarvte
Release Notes