Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Fix to delete PDP context on disconnect #10375

Merged
merged 1 commit into from Apr 17, 2019

Conversation

Projects
None yet
8 participants
@AriParkkila
Copy link
Contributor

commented Apr 11, 2019

Description

Delete cellular PDP context on NetworkInterface::disconnect if one was created while connecting.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jarvte

Release Notes

@ciarmcom ciarmcom requested review from jarvte and ARMmbed/mbed-os-maintainers Apr 11, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

@AriParkkila, thank you for your changes.
@jarvte @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@jarvte

jarvte approved these changes Apr 12, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

CI started

if (_new_context_set) {
delete_current_context();
}
_cid = -1;

This comment has been minimized.

Copy link
@AnttiKauppila

AnttiKauppila Apr 12, 2019

Contributor

delete_current_context() sets _cid to -1 only in successful case. What is the meaning of this line?

This comment has been minimized.

Copy link
@AriParkkila

AriParkkila Apr 12, 2019

Author Contributor

Disconnect must be set _cid = -1 to not expect any _cid to be valid/preferred on the next connect request, even when we did not create that _cid ourselves.

if (_new_context_set) {
delete_current_context();
}
_cid = -1;

This comment has been minimized.

Copy link
@AnttiKauppila

AnttiKauppila Apr 12, 2019

Contributor

Same as above

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 12, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added needs: review and removed needs: CI labels Apr 12, 2019

@cmonr cmonr added needs: work and removed needs: review labels Apr 12, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

@AnttiKauppila Are there any requests for changes left ?

@0xc0170 0xc0170 added needs: review and removed needs: work labels Apr 15, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 16, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 16, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Apr 16, 2019

@0xc0170 0xc0170 merged commit b2b2fce into ARMmbed:master Apr 17, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9824 cycles (-463 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.