Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPC55S69: Fix APB bridge security programming #10376

Merged
merged 2 commits into from
Apr 12, 2019

Conversation

kjbracey
Copy link
Contributor

Description

Spotted in compiler warnings - code was trying to access a non-existent second security control block, rather than access the settings for the second APB bridge in the first and only security control block.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Spotted in compiler warnings - code was trying to access a non-existent
second security control block, rather than access the settings for the
second APB bridge in the first and only security control block.
@orenc17
Copy link
Contributor

orenc17 commented Apr 11, 2019

@mmahadevan108 please review

@ciarmcom ciarmcom requested review from maclobdell, MarceloSalazar and a team April 11, 2019 13:00
@ciarmcom
Copy link
Member

@kjbracey-arm, thank you for your changes.
@MarceloSalazar @maclobdell @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from a team April 11, 2019 13:00
Copy link
Contributor

@mmahadevan108 mmahadevan108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix.

@cmonr
Copy link
Contributor

cmonr commented Apr 12, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 12, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 12, 2019

Exporters restarted - internal symlink error

@0xc0170 0xc0170 merged commit 71b12f9 into ARMmbed:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants