Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPC55S69: Fix APB bridge security programming #10376

Merged
merged 2 commits into from Apr 12, 2019

Conversation

Projects
None yet
7 participants
@kjbracey-arm
Copy link
Contributor

commented Apr 11, 2019

Description

Spotted in compiler warnings - code was trying to access a non-existent second security control block, rather than access the settings for the second APB bridge in the first and only security control block.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

kjbracey-arm added some commits Apr 11, 2019

LPC55S69: Fix APB bridge security programming
Spotted in compiler warnings - code was trying to access a non-existent
second security control block, rather than access the settings for the
second APB bridge in the first and only security control block.
@orenc17

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

@mmahadevan108 please review

@ciarmcom ciarmcom requested review from maclobdell, MarceloSalazar and ARMmbed/mbed-os-maintainers Apr 11, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

@kjbracey-arm, thank you for your changes.
@MarceloSalazar @maclobdell @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from ARMmbed/team-nxp Apr 11, 2019

@mmahadevan108
Copy link
Contributor

left a comment

Thank you for the fix.

@cmonr

cmonr approved these changes Apr 12, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 12, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Exporters restarted - internal symlink error

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 12, 2019

@0xc0170 0xc0170 merged commit 71b12f9 into ARMmbed:master Apr 12, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9980 cycles (-307 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.