Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the writing example in unit testing README #10391

Merged
merged 2 commits into from Apr 16, 2019

Conversation

Projects
None yet
6 participants
@lorjala
Copy link
Contributor

commented Apr 12, 2019

Description

The current unit testing writing example does not compile. To make sure the example works in the future we need to remove any code dependency from it. This new example is similar to the previous one, but uses dummy classes instead.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@OPpuolitaival @AnotherButler

@ciarmcom ciarmcom requested review from AnotherButler, OPpuolitaival and ARMmbed/mbed-os-maintainers Apr 12, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

@lorjala, thank you for your changes.
@AnotherButler @OPpuolitaival @ARMmbed/mbed-os-maintainers please review.

@cmonr

cmonr approved these changes Apr 15, 2019

@cmonr cmonr added needs: CI and removed needs: review labels Apr 15, 2019

Edit README.md
Edit file for consistent person.
@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

CI started

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 16, 2019

@0xc0170 0xc0170 merged commit 5e73a83 into ARMmbed:master Apr 16, 2019

15 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 9855 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.