Update the writing example in unit testing README #10391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lorjala, thank you for your changes. |
OPpuolitaival
approved these changes
Apr 12, 2019
cmonr
approved these changes
Apr 15, 2019
Edit file for consistent person.
AnotherButler
approved these changes
Apr 15, 2019
|
CI started |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current unit testing writing example does not compile. To make sure the example works in the future we need to remove any code dependency from it. This new example is similar to the previous one, but uses dummy classes instead.
Pull request type
Reviewers
@OPpuolitaival @AnotherButler