-
Notifications
You must be signed in to change notification settings - Fork 3k
Prevent stack overflow from general_block_device test. #10405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This test was failing randomly on NUCLEO_F412ZG using SDCard (https://jira.arm.com/browse/IOTSTOR-828).
@korjaa, thank you for your changes. |
Related ticket https://jira.arm.com/browse/IOTSTOR-828 |
CI started. |
@korjaa Why is this not targeting master but release branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have modified this test to address these issues. Does it still happen in the latest master?
Increasing stack size will hurt boards having low memory. I don't think this change is required.
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
@0xc0170 The tests have changed in the master branch to a shorter version (only one block operation per thread if I didn't read the log wrong) and I was not able to reproduce the issue. The block operations need to be done several times in multiple threads for the issue to show up. I feel the new tests are so short that they usually always pass. |
This PR is not valid against master as the test flow has changed in the master. However, I do still think this would useful for anyone using 5.12.x. But if patches are not accepted to releases, I'm not sure how a change like this can go in. |
Based on the feedback above, this can be closed. It was addressed on master, should not be present on release branch neither. |
This test was failing randomly on NUCLEO_F412ZG using SDCard (https://jira.arm.com/browse/IOTSTOR-828).
Description
Pull request type
Reviewers
Release Notes